Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser, ddl: correct the job type of 'REORGANIZE PARTITION' (#42490) #42494

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #42490

What problem does this PR solve?

Issue Number: close #42442

Problem Summary:

What is changed and how it works?

See the comments in #42442:

The root cause is that we didn't mark "reorganize partition" as "need backfill" so it is scheduled as the 'general job', and the 'general job' is scheduled in serial(always block each others).

This PR simply fixes this.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Like #42442, concurrently run CREATE TABLE and REORGANIZE PARTITION in 2 sessions:

session1(first)> alter table t1 reorganize partition p0, p1, p2, p3, p4 into( partition pnew values less than (10000000));
session2(second)> create table t01(a int, b int);

We can verify that create table will not be blocked anymore.

  • No code

Side effects

  • None

Documentation

  • None

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: bb7133 <bb7133@gmail.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Mar 22, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CbcWestwolf
  • bb7133

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Mar 22, 2023
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.0 labels Mar 22, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 23, 2023
@bb7133
Copy link
Member

bb7133 commented Mar 23, 2023

/retest

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2023
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 23, 2023
@bb7133
Copy link
Member

bb7133 commented Mar 23, 2023

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 54b84cb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2023
@bb7133
Copy link
Member

bb7133 commented Mar 23, 2023

/retest

4 similar comments
@mjonss
Copy link
Contributor

mjonss commented Mar 23, 2023

/retest

@bb7133
Copy link
Member

bb7133 commented Mar 23, 2023

/retest

@mjonss
Copy link
Contributor

mjonss commented Mar 23, 2023

/retest

@mjonss
Copy link
Contributor

mjonss commented Mar 23, 2023

/retest

@ti-chi-bot ti-chi-bot merged commit 69ae178 into pingcap:release-7.0 Mar 23, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants